iOS and OS X library dependencies #506
Conversation
|
@advayDev1 - do you know what line is needed for the podspec? I believe it's vendored_libraries. Are you using an OS X build at the moment? If you have an example, it would be helpful to submit it. |
| String libDirIosDebug = new File(getDestLibDirFile(), '/iosDebug').absolutePath | ||
| String libDirIosRelease = new File(getDestLibDirFile(), '/iosRelease').absolutePath | ||
| String libDirOsxDebug = new File(getDestLibDirFile(), '/x86_64Debug').absolutePath | ||
| String libDirOsxRelease = new File(getDestLibDirFile(), '/x86_64Release').absolutePath |
There was a problem hiding this comment.
i'm having second thoughts about the ordering here.
Does absolutePath function before the directory is created? I thought the FS actually resolves the path?
Until the AssembleLibrariesTask has run, j2objcOutputs/lib/BLAH is never created. Does this work for you after a ./gradlew clean then ./gradlew build?
There was a problem hiding this comment.
The ordering is fine. The absolutePath is resolved internally without referencing the FS. I can run j2objcPodspec and it happily refers to a non-existent directory. Then after running the full build, it now refers to a directory that exists. Indeed, the clean and then build is enforced by the run-test.sh script.
brunobowden
force-pushed
the
improve
branch
2 times, most recently
from
9647fc6
to
35ac04d
Compare
- separate iOS and OS X libraries for j2objc - separate iOS and OS X libraries built libraries - min deployment target (default): iOS (8.3), OS X (10.8) & watchOS (2.0) - Standardize buildType on uppercase ‘Debug’ and ‘Release’ - Link to ExceptionHandling library only on OS X Fixes j2objc-contrib#488
|
@advayDev1 - I've reworked this to add the deployment targets for iOS, OS X and watchOS. I'm going to try and setup a "allPlatforms" test that builds on all the platforms. What is the j2objcConfig to add the bitcode build? Given that this is only partially working, please review as is and then I'll work on a separate PR for the platform builds. |
| @@ -60,6 +60,14 @@ class Utils { | |||
| } | |||
| } | |||
|
|
|||
| static void validateVersion(String version, String type) { | |||
| // Requires at least a major and minor version number | |||
| Matcher versionMatcher = (version =~ /^[0-9]*(\.[0-9]+)+$/) | |||
There was a problem hiding this comment.
this prohibits -rc1, .beta, etc.
we know that won't happen?
There was a problem hiding this comment.
I've renamed it to validateNumericVersion and shifted it from Utils to PodspecTask, chaning it from an exception to a warning. I've never seen an Apple OS with a non numeric identifier but can't definitively confirm that there won't ever be one.
|
Build is failing due to the change re: case - see comments above. LGTM after that. Unfortunately I don't use bitcode nor do I know much about it. |
iOS and OS X library dependencies
Fixes #488